Issue323 Make IE compatible #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Array.prototype.find not supported yet in IE (switch to using regex) -Check for empty string before calling numeral functions -Avoid testing on alternate delimiters in numeral -- numeral does not seem to be returning correct values
The mechanism used to version these files is prone to error, because it does a global search and replace looking for the prior version and replacing it with the new version. If any versions have been skipped or any version number has been altered by hand, this won't work. The .dev files are not for release and so do not need to be versioned. The production files contain a banner which will automatically pull the right version number when the files are built.
victorjonsson
added a commit
that referenced
this pull request
Feb 18, 2016
Issue323 Make IE compatible
|
Superb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix was not IE compatible.
I changed the version task a bit, let me know if that's not ok.