-
Notifications
You must be signed in to change notification settings - Fork 471
Separate dev and prod files #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate dev and prod files #389
Conversation
Goals: -Separate dev and prod files -Allow for clean git commits -Reduce project clutter -Follow standard directory structure (source files in src and prod files in dist) The next commits in this series update project files as necessary Roll back
-Fix JSHint to check language files (it wasn't checking those before) -Fix JSHint errors -Add task to minify CSS -Bump dependencies -Reorganize tasks. Default task is now a dev task which watches directory for changes and does tests/builds upon changes, but not minification; "build-production" task bumps version, does tests, and minifies output
Running the default Grunt task now produces non-minified files, so this isn't necessary any more.
These are all great improvements indeed! Let's say that we decide to versionize the production files in the same repository, located in a directory named
If you take care of the npm publishing stuff and add me as an owner that would be great! |
What kind of versioning system is the project currently using? On 2/23/16, Victor Jonsson notifications@github.com wrote:
|
Separate dev and prod files
Could you elaborate on why the directory needs to be renamed from |
The main reason I had was that I think it should be immediately clear On 2/25/16, Victor Jonsson notifications@github.com wrote:
|
No that's okey. I just don't feel we need to rush the changing of the name. |
I agree, no rush |
These commits separate prod and src files into dedicated directories and get rid of the .dev.js extensions.
Prod files are minified for production builds and not minified for dev builds. (excluding the CSS file which is always minified, I'll fix that soon)
To match standard directory structure the prod directory should be labeled 'dist', but that is a breaking change so it should not be made until the next major version bump.
Let me know if these changes are okay or you'd prefer a different structure :)
I didn't realize when I started this that Bower simply copies files, which means we can't just .gitignore prod files. The alternative is to have a separate release branch and have Bower point to that. Both options aren't great :( .
Can we publish on npm? I can do the actual commands and any required set-up and add you as an owner if that is easiest (and remove myself after publishing if you'd prefer). I think it's really important to support NPM because it's such a big player in Javascript package management right now.