Add UMD to module files #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… does not exist and fail validation Previously, this would just throw an exception. Fix form.html validation of PW duplication fields
-Use glob patterns for Grunt tasks; don't loop through all files -Create separate copy task (this was previously bundled in with concat tasks and required making a separate task for every copied file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module files now should work with Browserify:
I also tested with RequireJS and that seems to works okay (but I haven't worked much with Require so perhaps it's clunkier than it needs to be).
I refactored the Gruntfile to use glob patterns; I also created a copy task specifically for copying (before it was part of the concat task, which I think was a bit misleading, and that also meant that we had to create a separate task for each file).