Add empty element check in case element was filtered by toggleDisabled #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the toggleDisabled plugin, you will get an exception without the check I've added if you try filtering out a form
https://github.com/BrianRosamilia/jQuery-Form-Validator/blob/master/src/modules/toggleDisabled.js#L34-L91
On line 34, the plugin is filtering out elements and on line 91 you're calling
validateOnEvent.thiswill actually be an empty jQuery object if there was a form element that was filtered bytoggleDisabled. This causes an exception when you callvalidateOnEvent(due to the assumed existence of this[0])I don't have a POC but hopefully this is an uncontroversial change since
this[0].without a length === 0 check can always potentially cause an exception. Thanks! 👍