Removed memory leak due to setInterval in js.#29
Closed
trokhymchuk wants to merge 1 commit intovinibiavatti1:masterfrom
Closed
Removed memory leak due to setInterval in js.#29trokhymchuk wants to merge 1 commit intovinibiavatti1:masterfrom
trokhymchuk wants to merge 1 commit intovinibiavatti1:masterfrom
Conversation
Owner
|
Hi @trokhymchuk! Thanks for reporting this issue. It was a big problem of the lib. I already fixed it and made other changes into the source code file that contains this logic, so, I will close the PR but the fix will be available in the next version v2.1.1 ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently noticed a memory leak in the site with this library, after some investigation I found the place --- it was setInterval function.
You could try inserting
console.log('test');afterconst interval = setInterval(() => {line, it will print infinite number of messages.