-
Notifications
You must be signed in to change notification settings - Fork 33
Wrap @import to ignore #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looking forward to it |
+1 |
@peyman3d @FaridAghili @jd-0001 Is problem still actual? I add test for it, and it passes |
@vkalinichev
@import '~bootstrap/dist/css/bootstrap.css';
/*rtl:begin:ignore*/
@import '~owl.carousel/dist/assets/owl.carousel.css';
/*rtl:end:ignore*/
// more codes ... It's expected that OwlCarousel be ignored here (Cause it supports RTL by default and doesn't need to be RTLed), but it's still processed and RTLed. laravel-mix: 5.0.1 |
Hmm... Can you provide your postcss config? Maybe another plugins strips out the ignore-directives or something like that? |
I'm using laravel-mix in a Laravel project.
const mix = require('laravel-mix');
mix.sass('resources/sass/app.scss', 'public/css')
.options({
postCss: [
require('postcss-rtl')({
onlyDirection: 'rtl'
})
]
});
{
"private": true,
"scripts": {
"dev": "npm run development",
"development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
"watch": "npm run development -- --watch",
"watch-poll": "npm run watch -- --watch-poll",
"hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
"prod": "npm run production",
"production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
},
"devDependencies": {
"bootstrap": "^4.4.1",
"cross-env": "^7.0",
"jquery": "^3.4.1",
"laravel-mix": "^5.0.1",
"owl.carousel": "^2.3.4",
"popper.js": "^1.16.1",
"postcss-rtl": "^1.7.0",
"resolve-url-loader": "^3.1.1",
"sass": "^1.25.0",
"sass-loader": "^8.0.2",
"vue-template-compiler": "^2.6.11"
}
} |
Experiencing the same issue with Owl Carousel |
the same issue I can't ignore CSS files |
Probably is a Webpack issue in production mode. (When comments are striped).
Tested in Nuxt 2.12 & Laravel Mix 4 |
@mhrabiee does't work on quasar framework :( |
@mhrabiee @miladmeidanshahi doesn't work on laravel-mix 5 neither. also tried this with no success. |
@mhrabiee dadash kheili giram :)) |
Any solution for this on Quasar? 😢 |
In new Quasar:
|
@miladmeidanshahi We are facing the same issue with Quasar, would you clarify the solution you used or explain your comment
|
Thanks to @ahmedqasid for helping me doing the solution that I will discuss with you. In Quasar, you can create your own plugin and add use it. Step 1. Create your plugin
Step 2. Add your plugin to CSS preprocessors:
This will add ignore prefix and suffix comments to any file in the AG-Grid library. |
Hi,
I want to ignore a package that is importing from node_modules. What can i do about it?
I tried 2 ways:
First one:
And second one:
But neither works! any solution?
The text was updated successfully, but these errors were encountered: