Skip to content

[css-typed-om] update CSSPerspectiveValue to accept perspective(none) #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbaron opened this issue Oct 12, 2021 · 1 comment · Fixed by #1053
Closed

[css-typed-om] update CSSPerspectiveValue to accept perspective(none) #1051

dbaron opened this issue Oct 12, 2021 · 1 comment · Fixed by #1053
Assignees
@dbaron
Labels
css-typed-om-1

Comments

@dbaron
Copy link
Member

dbaron commented Oct 12, 2021 •
edited
Loading

In w3c/csswg-drafts#6488 the CSS Working Group resolved to add perspective(none) and it was added in w3c/csswg-drafts#6691 .

This requires updates to CSSPerspective.

It's not clear to me if the best way to make these updates is by changing CSSNumericValue to CSSStyleValue or changing it to (CSSNumericValue or CSSKeywordValue), or perhaps (although probably not) to CSSNumericValue?.

Maybe @tabatkins or others have opinions on this?
@dbaron dbaron self-assigned this Oct 12, 2021
@tabatkins
Copy link
Member

It should be (CSSNumericValue or CSSKeywordValue); that's how it'll be reflected from syntax into Typed OM.

dbaron added a commit to dbaron/css-houdini-drafts that referenced this issue Oct 13, 2021
@dbaron
[css-typed-om] Add support for perspective(none) to CSSPerspective.
3184e20 
This adds support for the none argument to the perspective() transform
function to CSSPerspective.

Fixes w3c#1051.
@dbaron dbaron mentioned this issue Oct 13, 2021
Merged
dbaron added a commit to w3c/csswg-drafts that referenced this issue Oct 13, 2021
@dbaron
[css-transforms-2] Export the definition of perspective(none).
32de8e5 
This is an additional change for #6488, also needed for a followup to
w3c/css-houdini-drafts#1051.
dbaron added a commit to dbaron/css-houdini-drafts that referenced this issue Oct 13, 2021
@dbaron
[css-typed-om] Followups to support for perspective(none), fixing cas…
2fcd6d3 
…e handling and linking of 'none'.

This is two additional changes for w3c#1051.
@dbaron dbaron mentioned this issue Oct 13, 2021
Merged
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 13, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
e67705f 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 14, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
3fb3eef 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 14, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
344ea62 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 14, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
d1aeabc 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 15, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
58a8af2 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 15, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
f6901ef 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 15, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
12638b9 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 16, 2021
@dbaron @chromium-wpt-export-bot
Add support for perspective(none) transform function.
58a3fe3 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Oct 16, 2021
@dbaron
Add support for perspective(none) transform function.
ae6f9bd 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 18, 2021
@chromium-wpt-export-bot
Revert "Add support for perspective(none) transform function."
25cbaa8 
This reverts commit ae6f9bdb7e14b19650ee21cba03418ed35f1a2f5.

Reason for revert: crbug.com/1260891

Original change's description:
> Add support for perspective(none) transform function.
>
> This adds support for the none value of the perspective() function of
> the transform property, and makes corresponding changes to the
> css-typed-om implementation.
>
> The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
> correspond both to the interpolation changes in this patch and also some
> that should have been included in https://crrev.com/c/2924023 (to keep
> the compositor animation behavior matching the blink animation
> behavior).  The added web-platform-tests in
> css/css-transforms/animation/transform-interpolation-perspective.html
> css/css-transforms/animation/support/transform-interpolation-reftests.js
> test for the need for both sets of changes to this code.
>
> The spec changes are linked from:
> w3c/csswg-drafts#6488
> w3c/css-houdini-drafts#1051
>
> Fixed: 1253596
> Bug: 1205161
> Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
> Reviewed-by: Kevin Ellis <kevers@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: David Baron <dbaron@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#932253}

Bug: 1205161
Change-Id: Idb9332196c09ee6e4ff57f740419531465ef0148
Closed
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 29, 2021
@dbaron @moz-wptsync-bot
Bug 1734704 [wpt PR 31158] - Add support for perspective(none) transf…
f254308 
…orm function., a=testonly

Automatic update from web-platform-tests
Add support for perspective(none) transform function.

This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}

--

wpt-commits: 58a3fe3ce41a3eb164966c744baccd4ce459f07c
wpt-pr: 31158
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 1, 2021
@dbaron @moz-wptsync-bot
Bug 1734704 [wpt PR 31158] - Add support for perspective(none) transf…
daf68e7 
…orm function., a=testonly

Automatic update from web-platform-tests
Add support for perspective(none) transform function.

This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}

--

wpt-commits: 58a3fe3ce41a3eb164966c744baccd4ce459f07c
wpt-pr: 31158
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
@dbaron @Gabisampaio
Add support for perspective(none) transform function.
4ab886a 
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.

The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior).  The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.

The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051

Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbaron dbaron

Labels
css-typed-om-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-typed-om] Add support for perspective(none) to CSSPerspective. dbaron/css-houdini-drafts
2 participants
@dbaron @tabatkins