Skip to content

[worklets] fetch a module script tree #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annevk opened this issue Apr 5, 2017 · 0 comments · Fixed by #375
Closed

[worklets] fetch a module script tree #372

annevk opened this issue Apr 5, 2017 · 0 comments · Fixed by #375
Assignees
@bfgeek
Labels
worklets-1

Comments

@annevk
Copy link
Member

annevk commented Apr 5, 2017

The arguments to fetch a module script tree changed.

Please work with @domenic to fix https://drafts.css-houdini.org/worklets/#creating-a-workletglobalscope.
bfgeek added a commit that referenced this issue Apr 6, 2017
@bfgeek
[worklets] Multiple fixes to the {{Worklet/import()}} algorithm.
3a1d624 
Instead of relying on "in parallel" this change makes all the thread
hopping explicit via. message passing and queue tasks on the appropriate
event loop.

 - Fixes #372, changes arguments to fetch a module script graph.

 - Fixes #370, running scripts in parallel. Now the script explicitly are
   run within a task queued on the worklet global scope's event loop.

 - Fixes #318, actually runs the event loop.

 - Fixes #230, treats "fetch a module worker script graph" as
   asynchronous.

 - Probably fixes #225 ? I think I'm grabbing the correct state at each
   thread hop.
@bfgeek bfgeek mentioned this issue Apr 6, 2017
Merged
@tabatkins tabatkins added the ready label Apr 6, 2017
bfgeek added a commit that referenced this issue Apr 11, 2017
@bfgeek
[worklets] Multiple fixes to the {{Worklet/import()}} algorithm. (#375)
7c5c4f8 
* [worklets] Multiple fixes to the {{Worklet/import()}} algorithm.

Instead of relying on "in parallel" this change makes all the thread
hopping explicit via. message passing and queue tasks on the appropriate
event loop.

 - Fixes #372, changes arguments to fetch a module script graph.

 - Fixes #370, running scripts in parallel. Now the script explicitly are
   run within a task queued on the worklet global scope's event loop.

 - Fixes #318, actually runs the event loop.

 - Fixes #230, treats "fetch a module worker script graph" as
   asynchronous.

 - Probably fixes #225 ? I think I'm grabbing the correct state at each
   thread hop.
@tabatkins tabatkins removed the ready label Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfgeek bfgeek

Labels
worklets-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[worklets] Multiple fixes to the {{Worklet/import()}} algorithm. w3c/css-houdini-drafts
3 participants
@tabatkins @bfgeek @annevk