Skip to content

[css-typed-om] What is CSSMathValue.type? #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
darrnshn opened this issue Oct 19, 2017 · 4 comments
Closed

[css-typed-om] What is CSSMathValue.type? #492

darrnshn opened this issue Oct 19, 2017 · 4 comments
Labels
css-typed-om-1 Needs Edits

Comments

@darrnshn
Copy link
Collaborator

I'm probably missing something here, but what is CSSMathValue.type? The spec mentions what type of a CSSMathValue should be, but that type links to CSSNumericValue.type, which is a map not a string.
@tabatkins
Copy link
Member

It's a remnant of the world before we made things more complex. This seems like basically a dupe of #482, right?

@darrnshn
Copy link
Collaborator Author

Ah right, does that mean we could just remove CSSMathValue.type, since it inherits CSSNumericValue's type() method?

@tabatkins
Copy link
Member

Yeah, we should.

@nainar nainar mentioned this issue Oct 25, 2017
Merged
@nainar
Copy link
Contributor

nainar commented Oct 26, 2017

Fixed by #497

@nainar nainar closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-typed-om-1 Needs Edits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tabatkins @nainar @darrnshn