Remove CSSMathValue.type #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
requested changes
Oct 25, 2017
css-typed-om/Overview.bs
Outdated
| :: The [=type=] is the same as the [=type=] of its {{CSSMathNegate/value}} internal slot, | ||
| but with all [=map/values=] negated. | ||
| </dl> | ||
| </div> |
There was a problem hiding this comment.
No, all of this needs to stay - it defines the type of a CSSMathValue. We just need to remove the .type member in the IDL, since that's carried by the superclass. The superclass's definition of .type will then figure out how to translate the type into some JS object.
There was a problem hiding this comment.
I think there's actually two we need to remove: CSSMathValue.type and CSSUnitValue.type?
There was a problem hiding this comment.
Ahhh I for some reason thought this had been copied twice. :/ Gotcha. Making the change. g
tabatkins
approved these changes
Oct 26, 2017
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Dec 27, 2017
type attribute was removed in CSSUnitValue.idl https://drafts.css-houdini.org/css-typed-om-1/#cssunitvalue w3c/css-houdini-drafts#497 Bug: 797668 Change-Id: Ic29193979f3336d735f6484ba199c652753e7ca0 Reviewed-on: https://chromium-review.googlesource.com/844305 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#526203}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #492.