Skip to content

Change credentials mode default #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annevk opened this issue May 2, 2018 · 6 comments
Closed

Change credentials mode default #756

annevk opened this issue May 2, 2018 · 6 comments

Comments

@annevk
Copy link
Member

annevk commented May 2, 2018

We shouldn't use "omit" as a default. We should use "same-origin" for web developer convenience. See whatwg/html#3656. (Note that fetch() already changed to no longer have this as a default.)

Fixing this will also require changing https://github.com/w3c/web-platform-tests/blob/master/worklets/resources/credentials-tests.js.

cc @nhiroki
@nhiroki
Copy link
Contributor

nhiroki commented May 2, 2018

Chromium issue: https://crbug.com/838540

Should we remove credentials field from WorkletOptions like changes for the worker spec, or remove WorkletOptions entirely?

@nhiroki
Copy link
Contributor

nhiroki commented May 2, 2018

I'll update the WPTs and Chromium implementation after the spec change is clarified.

@annevk
Copy link
Member Author

annevk commented May 2, 2018

@nhiroki note that @domenic suggested we keep credentials and just flip the default. I guess I'm good either way, though currently we don't offer "omit" outside of fetch().

@nhiroki
Copy link
Contributor

nhiroki commented May 2, 2018

@annevk Thank you! I forgot the domenic's comment in the PR :) I'll change them in that way.

@nhiroki nhiroki mentioned this issue May 8, 2018
Merged
bfgeek pushed a commit that referenced this issue May 8, 2018
@nhiroki @bfgeek
[worklets] Change the default credentials mode from 'omit' to 'same-o…
06d6906 
…rigin' (#757)

Issue: #756
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 9, 2018
@nhiroki @chromium-wpt-export-bot
Worklet: Change the default credentials mode from 'omit' to 'same-ori…
4db734c 
…gin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
aarongable pushed a commit to chromium/chromium that referenced this issue May 10, 2018
@nhiroki
Worklet: Change the default credentials mode from 'omit' to 'same-ori…
2c792e6 
…gin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 10, 2018
@nhiroki @chromium-wpt-export-bot
Worklet: Change the default credentials mode from 'omit' to 'same-ori…
7b88451 
…gin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 10, 2018
@nhiroki @chromium-wpt-export-bot
Worklet: Change the default credentials mode from 'omit' to 'same-ori…
218c751 
…gin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}
@nhiroki
Copy link
Contributor

nhiroki commented May 10, 2018

Fixed Chromium impl and WPTs. Can you close this issue?

@annevk
Copy link
Member Author

annevk commented May 10, 2018

And the specification changed with #757. Thanks!

@annevk annevk closed this as completed May 10, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 18, 2018
@nhiroki @jgraham
Bug 1460460 [wpt PR 10943] - Worklet: Change the default credentials …
10aaf09 
…mode from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}

--

wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943
@nhiroki nhiroki mentioned this issue May 21, 2018
Merged
sole pushed a commit to sole/gecko that referenced this issue May 21, 2018
@nhiroki @jgraham
Bug 1460460 [wpt PR 10943] - Worklet: Change the default credentials …
7429cee 
…mode from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}

--

wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1460460 [wpt PR 10943] - Worklet: Change the default credentials …
f8123ac 
…mode from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falkenchromium.org>
Commit-Queue: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#557467}

--

wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943

UltraBlame original commit: a18ba7f66f6084d3bf660386f2268c44f301976e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1460460 [wpt PR 10943] - Worklet: Change the default credentials …
304fb65 
…mode from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falkenchromium.org>
Commit-Queue: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#557467}

--

wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943

UltraBlame original commit: a18ba7f66f6084d3bf660386f2268c44f301976e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1460460 [wpt PR 10943] - Worklet: Change the default credentials …
2155cc0 
…mode from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'

According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.

Spec issue: w3c/css-houdini-drafts#756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432

Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falkenchromium.org>
Commit-Queue: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#557467}

--

wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943

UltraBlame original commit: a18ba7f66f6084d3bf660386f2268c44f301976e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhiroki @annevk