Skip to content

[css-animationworklet] Consider reworking 'Interaction with Animator Instances' section #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenmcgruer opened this issue Mar 28, 2019 · 0 comments
Assignees
Labels

Comments

@stephenmcgruer
Copy link
Contributor

It is quite hard to find the "override" behavior specified in the 'Interaction with Animator Instances' section:

When a given workletAnimation’s play state changes to pending, running, or paused, run the procedure to associate animator instance of worklet animation given workletAnimation.

When a given workletAnimation’s play state changes to idle or finished, run the procedure to disassociate animator instance of worklet animation given workletAnimation.

When the procedure to set the target effect of an animation for a given workletAnimation is called, then set animator instance of worklet animation given workletAnimation.

When the procedure to set the timeline of an animation for a given workletAnimation is called, then set animator instance of worklet animation given workletAnimation.

For example, when reading Creating a Worklet Animation, step 4:

Run the procedure to set the target effect of an animation on workletAnimation passing effect as the new effect.

It is difficult-to-impossible for a naive reader to realize that this step actually also sets the animator instance, as it is not mentioned in either the text or the link.

My suggestions would be to:

  • Clearly mark the area where we override Web Animations concepts as 'extensions to Web Animations APIs' or similar, and
  • From the AnimationWorklet spec at least, link to that section rather than the Web Animations API where appropriate (e.g. in the WorkletAnimation creation steps).
@tabatkins tabatkins added the css-animationworklet-1 CSS AnimationWorklet API label May 7, 2019
@majido majido self-assigned this Jun 6, 2019
majido added a commit to majido/css-houdini-drafts that referenced this issue Jul 25, 2019
majido added a commit that referenced this issue Aug 6, 2019
* Improve wording on how worklet animation interacts with web-animations (issue #870)
* Update web-animations spec link to be https://drafts.csswg.org which is more recent
* Add section to deal with addition of "replace state" in Web animations.
* Add issue to indicate our current shortcoming for async operations.
* lots of small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants