Skip to content

[css-animationworklet] Need a document animator definition and verification #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
flackr opened this issue Aug 15, 2019 · 1 comment
Open

[css-animationworklet] Need a document animator definition and verification #928

flackr opened this issue Aug 15, 2019 · 1 comment
Assignees
@majido
Labels
css-animationworklet-1 CSS AnimationWorklet API

Comments

@flackr
Copy link
Contributor

flackr commented Aug 15, 2019 •
edited
Loading

animator definition describes the definition of an animator on the worklet but given that implementations may have multiple worklets we need a document animator definition concept (analogous to document paint definition) and document animator definition map which describes the main context's concept of valid animators. This should be referred to when creating AnimationWorklets, and definitions verified or rejected when registering animators (Similar to step 22 of Registering a custom paint).
@majido majido added the css-animationworklet-1 CSS AnimationWorklet API label Sep 16, 2019
majido added a commit that referenced this issue Oct 25, 2019
@majido
[css-animationworklet-1] Add document definitions (#928)
ed84d19 
Add document animator definition and corressponding map.

This ensures when registering an animator inside multiple global
scope, it is not valid to register different types of classes.
At the moment the only difference can be between statefullness.
This document animator map is also consulted when constructing
a worklet animation to reject use of an invalid (unregistered)
name.

Also updated the prose to use map from infra spec which is more
concrete and in line with paint worklet spec.
@majido
Copy link
Contributor

majido commented Oct 25, 2019

This should be fixed now.

The PR adds document animator definition and corresponding map. The map is consulted and updated during registration process.At the moment, the only possible difference between two registration is the "statefullness". In future if we add inputProperties those could also create potential for difference.

Also updated the prose to use map from infra spec which is moreconcrete and in line with paint worklet spec.

@majido majido self-assigned this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majido majido

Labels
css-animationworklet-1 CSS AnimationWorklet API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flackr @majido