Skip to content

Add type checking to CSSNumericValue.parse #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tabatkins merged 1 commit into from
Jan 28, 2022
Merged

Add type checking to CSSNumericValue.parse #1065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add type checking to CSSNumericValue.parse 
Fixes #1064
  • Loading branch information
@xiaochengh
xiaochengh authored Jan 27, 2022
commit 1bfa1b3ea6fad95509cbeb4fb5d40b1be0678bca
7 changes: 6 additions & 1 deletion css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,8 +1695,13 @@ rather than on {{CSSNumericValue}} instances.
or a [=math function=],
[=throw=] a {{SyntaxError}}
and abort this algorithm.

3. If |result| is a <<dimension-token>>
and [=creating a type=] from |result|'s unit returns failure,
[=throw=] a {{SyntaxError}}
and abort this algorithm.

3. [=Reify a numeric value=] |result|,
4. [=Reify a numeric value=] |result|,
and return the result.
</div>

Expand Down