[CSS-Typed-OM] Change reifying as from 'a CSSStyleValue' to 'an identifier'#1068
Merged
Conversation
Step 2 of parse() [1] says "Reify a color value from result ". However, "Reify a color value" algorithm [2] needs a second parameter, which is a property to be consumed by step 9 only. Therefore, Change step 9 from 'CSSStyleValue' to 'an identifier'[3] for reifying. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-csscolorvalue-parse [2] https://drafts.css-houdini.org/css-typed-om-1/#reify-a-color-value [3] https://drafts.css-houdini.org/css-typed-om-1/#reify-an-identifier
The reify a color value algorithm no more need |prop|. Hence, Remove the |prop| parameter of 'reifying a color value'.
Contributor
|
@tabatkins Could you ptal? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of parse() [1] says "Reify a color value from result ".
However, "Reify a color value" algorithm [2] needs a second parameter,
which is a property to be consumed by step 9 only.
Therefore, Change step 9 from 'CSSStyleValue' to 'an identifier'[3] for reifying.
And the reify a color value algorithm no more need |prop|.
Hence, Remove the |prop| parameter of 'reifying a color value'.
[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-csscolorvalue-parse
[2] https://drafts.css-houdini.org/css-typed-om-1/#reify-a-color-value
[3] https://drafts.css-houdini.org/css-typed-om-1/#reify-an-identifier
Working Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/3522201
csswg issue: w3c/csswg-drafts#7174
cc. @xiaochengh