[css-properties-values-api] Make var() fallback type-agnostic #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Issue 10455.
Member
Author
emilio
approved these changes
Mar 7, 2025
Contributor
emilio
left a comment
There was a problem hiding this comment.
Do you know if tests for this have already been updated?
Contributor
|
We should probably move this spec to csswg-drafts proper at this point btw. |
Member
Author
I checked this morning, and they were not updated then. (I will do it when I make the change in Blink.) |
Contributor
|
Ok, filed https://bugzilla.mozilla.org/show_bug.cgi?id=1952516 for this. If you have the test changes around feel free to send them, otherwise I can fix them up next week or just wait for your change, as you prefer (I'm on PTO technically today, so about to go enjoy the sun a little bit :P) |
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 11, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1952516 gecko-commit: 43a3d9200eb2297096d7174ce6aba3a7e597ab6c gecko-reviewers: dshin
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 12, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 12, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1952516 gecko-commit: 43a3d9200eb2297096d7174ce6aba3a7e597ab6c gecko-reviewers: dshin
github-actions bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Mar 12, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Mar 13, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 18, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
See w3c/css-houdini-drafts#1139 and linked CSSWG issue. Anders will update the tests before landing. Differential Revision: https://phabricator.services.mozilla.com/D240731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves w3c/csswg-drafts#10455.