Skip to content

Add prose regarding SyntaxError #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shans merged 7 commits into from
Apr 7, 2016
Merged

Add prose regarding SyntaxError #174

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c06ae22
Add prose regarding SyntaxError
Apr 4, 2016
830fc58
Incorporate examples and remove SyntaxError on fromValue and fromDict…
Apr 4, 2016
c87fa87
merge
Apr 4, 2016
3fbcafa
merge
Apr 4, 2016
036bb61
Merge branch 'master' into issue166
Apr 4, 2016
99861ad
add error info inline to function description
Apr 4, 2016
0c325d3
incorporate suggested changes
Apr 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,10 @@ dictionary CalcDictionary {
};

interface LengthValue : StyleValue {
LengthValue add(LengthValue value); // can throw
LengthValue subtract(LengthValue value); // can throw
LengthValue multiply(double value); // can throw
LengthValue divide(double value); // can throw
LengthValue add(LengthValue value);
LengthValue subtract(LengthValue value);
LengthValue multiply(double value);
LengthValue divide(double value);
static LengthValue parse(DOMString cssText);
static LengthValue fromValue(double value, LengthType type);
static LengthValue fromDictionary(CalcDictionary dictionary);
Expand Down Expand Up @@ -383,11 +383,11 @@ The following methods are defined for {{LengthValue}} objects:
:: Divides the length represented by the object by the provided <var>value</var>,
and returns the result as a new {{LengthValue}}. This will construct
a {{SimpleLength}} if the object is a {{SimpleLength}}, or a {{CalcLength}}
if the object is a {{CalcLength}}.
if the object is a {{CalcLength}}. The function will throw a {{DivideByZeroError}} when the value given is 0.

: <dfn method for=LengthValue>parse(DOMString cssText)</dfn>
:: Parses the provided <var>cssText</var> as a length value. Will return a
{{SimpleLength}} when possible, or a {{CalcLength}} otherwise.
{{SimpleLength}} when possible, or a {{CalcLength}} otherwise. The function will throw a {{SyntaxError}}, when the DOMString it is passed doesn't represent a valid length.

: <dfn method for=LengthValue>fromValue(double value, LengthType type)</dfn>
:: Constructs a {{SimpleLength}} with the given <var>value</var> and unit
Expand All @@ -397,8 +397,6 @@ The following methods are defined for {{LengthValue}} objects:
:: Constructs a {{CalcLength}} with units and values as defined by the provided
dictionary.

Issue(166): What happens if the provided DOMString or LengthValue for (e.g.) a SimpleLength is invalid?

{{TransformValue}} objects {#transformvalue-objects}
-----------------------------------------------------------

Expand Down