[css-typed-om] clarify how CSSUnparsedValues compute. #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Furthermore, values that at specified value time contained custom property references | ||
| are renormalized after computation. | ||
| A property with a specified {{CSSUnparsedValue}} value will not | ||
| compute to a {{CSSUnparsedValue}}. Instead, after custom property references |
There was a problem hiding this comment.
will not automatically compute
Because they can still compute to that, if they're custom properties without a syntax.
|
Discussed with @tabatkins offline - decided that it's correct to use CSSUnparsedValue only when there are unresolved variable references and CSSStyleValue otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#192)