[css-paint-api] Removes invalidation based on size, and allows user-a… #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gents to cache. Fixes #326. I realized that explicitly placing an invalidation based on size here was wrong, e.g. if a box changes size it has to run the "object size negotiation" algorithm, which makes invalidating the paint() function off size redundant. Additionally allows user-agents to cache results from previous invocations, and re-use. This allows UAs to re-use images between instances if they have the same input style, concrete object size, and input arguments.
|
@tabatkins @dbaron Does this make sense? We can talk about it at houdini tues. |
|
Yeah, this looks good; when you described it in the meeting I didn't realize you'd added that additional wording. The one minor comment is that "is expected to be run" should probably be a more normative phrase -- maybe must, although maybe should if there's a good reason for it not to be must. |
|
Thanks, changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gents to cache.
Fixes #326.
I realized that explicitly placing an invalidation based on size here
was wrong, e.g. if a box changes size it has to run the "object size
negotiation" algorithm, which makes invalidating the paint() function
off size redundant.
Additionally allows user-agents to cache results from previous
invocations, and re-use. This allows UAs to re-use images between
instances if they have the same input style, concrete object size, and
input arguments.