[css-properties-values-api] Typed custom property declarations are syntax-checked at computed-value time, not parse time.#427
Closed
jyc wants to merge 1 commit into
Closed
Conversation
…ntax-checked at computed-value time, not parse time. Clarify that the `syntax` field is used during computed-value time, write in the section about calculation of computed values that declarations can be found invalid at computed-value time, and update the example which previously indicated syntax-checking at parse time. Per Seattle resolution, as expressed in the following comments: > The original issue (should a property fail at parse-time if a typed > custom property is used in a wrong way, per the property's grammar) is, > I think, a no. I believe this falls out of our decision at the Seattle > f2f (w3c#354) that registering a custom property shouldn't require an > immediate global re-parse. You can do wrong things to/with a typed > custom property; it'll just cause a failure at computed-value time, like > an untyped custom property with an incompatible value does. > > - w3c#321 (comment) > Further clarification: per Seattle resolution, when using a typed > property in a stylesheet, setting to an invalid value doesn't trigger > fallback ... > > - w3c#354 (comment)
Member
|
@tabatkins , perhaps you could review this pull request (or suggest another Properties & Values spec-editor to review it)? |
Member
|
@tabatkins @jyc I think this is resolved by 8dfc2d9 , close? |
Member
|
Yup, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the
syntaxfield is used during computed-value time,write in the section about calculation of computed values that
declarations can be found invalid at computed-value time, and update the
example which previously indicated syntax-checking at parse time.
Per Seattle resolution, as expressed in the following comments: