Skip to content

Refactor out value type-checking logic from CSSStyleValue.append to fix issue #145 #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shans merged 4 commits into from
Jul 25, 2017
Merged

Refactor out value type-checking logic from CSSStyleValue.append to fix issue #145 #429

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
263ad23
refactor out value type-checking logic from CSSStyleValue.append to f…
nainar Jul 25, 2017
add576d
Remove issue from spec
nainar Jul 25, 2017
89374a6
Fix up algorithm referencing
nainar Jul 25, 2017
0568b44
fix merge conflict and grammar issue
nainar Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up algorithm referencing
  • Loading branch information
@nainar
nainar committed Jul 25, 2017
commit 89374a62da57faca16a7df68121d1b07912450b0
5 changes: 2 additions & 3 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,13 @@ The <dfn method for=StylePropertyMap>append(DOMString <var>property</var>,

5. Let |values to append| be the empty list.

6. For each |value| in |values| if the [=algorithm to check if any given value is of a certain type=] described below exits
gracefully append the returned object to |values to append|
6. For each |value| in |values| if the [=algorithm that coerces value into an appropriate type for a given property=] does not throw an error, append the returned object to |values to append|.

7. Append |values to append| to the end of |entry|’s list.
</div>

<div algorithm>
Copy link
Copy Markdown
Contributor

@shans shans Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this algorithm coerces |value| into an appropriate type, as it attempts to convert DOMStrings. Also describe how it fails (i.e. by throwing a TypeError)

Copy link
Copy Markdown
Contributor Author

@nainar nainar Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

This section describes the <dfn>algorithm to check if any given |value| is of a certain type</dfn>:
This section describes the <dfn>algorithm that coerces value into an appropriate type for a given property</dfn>, por fails and throws a {{TypeError}}:
Copy link
Copy Markdown
Contributor

@shans shans Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/por/or/

: If |value| is a {{CSSStyleValue}},
:: If |value| does not match the grammar of a [=list-valued property iteration=] of |property|,
[=throw=] a {{TypeError}} and exit this algorithm.
Expand Down