Skip to content

CSSNumericValue.from() -> CSSNumericValue.to()#476

Closed
nainar wants to merge 1 commit into
w3c:masterfrom
nainar:typo_from_to
Closed

CSSNumericValue.from() -> CSSNumericValue.to()#476
nainar wants to merge 1 commit into
w3c:masterfrom
nainar:typo_from_to

Conversation

@nainar
Copy link
Copy Markdown
Contributor

@nainar nainar commented Oct 13, 2017

There were still 2 references to CSSNumericValue.from() -> I changed those to CSSNumericValue.to()

@nainar nainar requested a review from shans October 13, 2017 04:16
@tabatkins
Copy link
Copy Markdown
Member

tabatkins commented Oct 13, 2017

from wasn't turned into to; from was the more generic factory function. It was replaced by parse in the first instance, and the CSSUnitValue constructor in the second instance (or CSS.px()).

@nainar
Copy link
Copy Markdown
Contributor Author

nainar commented Oct 15, 2017

Closing in favor of #480

@nainar nainar closed this Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shans shans Awaiting requested review from shans

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nainar @tabatkins