Skip to content

Make CSSNumericValue members readonly #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Make CSSNumericValue members readonly #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,7 @@ are represented as {{CSSUnitValue}}s.
[Constructor(double value, DOMString unit)]
interface CSSUnitValue : CSSNumericValue {
attribute double value;
attribute DOMString unit;
readonly attribute DOMString unit;
};
</xmp>

Expand All @@ -1588,21 +1588,6 @@ are represented as {{CSSUnitValue}}s.
and its {{CSSUnitValue/unit}} set to |unit|.
</div>

<div algorithm="CSSUnitValue.unit">
The <dfn attribute for=CSSUnitValue>unit</dfn> attribute of a {{CSSUnitValue}} |this| must,
on setting a value |unit|,
perform the following steps:

1. If [=creating a type=] from |unit| returns failure,,
[=throw=] a {{TypeError}}.

2. Otherwise,
set |this|’s {{CSSUnitValue/unit}} internal slot to |unit|.

On reading,
it must return the value of |this|’s {{CSSUnitValue/unit}} internal slot.
</div>

<div algorithm>
The <dfn>[=type=] of a {{CSSUnitValue}}</dfn>
is the result of [=creating a type=] from its {{CSSUnitValue/unit}} internal slot.
Expand Down Expand Up @@ -1681,32 +1666,32 @@ interface CSSMathValue : CSSNumericValue {

[Constructor(CSSNumberish... args)]
interface CSSMathSum : CSSMathValue {
attribute CSSNumericArray values;
readonly attribute CSSNumericArray values;
};

[Constructor(CSSNumberish... args)]
interface CSSMathProduct : CSSMathValue {
attribute CSSNumericArray values;
readonly attribute CSSNumericArray values;
};

[Constructor(CSSNumberish arg)]
interface CSSMathNegate : CSSMathValue {
attribute CSSNumericValue value;
readonly attribute CSSNumericValue value;
};

[Constructor(CSSNumberish arg)]
interface CSSMathInvert : CSSMathValue {
attribute CSSNumericValue value;
readonly attribute CSSNumericValue value;
};

[Constructor(CSSNumberish... args)]
interface CSSMathMin : CSSMathValue {
attribute CSSNumericArray values;
readonly attribute CSSNumericArray values;
};

[Constructor(CSSNumberish... args)]
interface CSSMathMax : CSSMathValue {
attribute CSSNumericArray values;
readonly attribute CSSNumericArray values;
};

interface CSSNumericArray {}; // See issue below
Expand Down