Skip to content

[css-properties-values-api] "Consume a name" returns a string. #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

andruud
Copy link
Member

@andruud andruud commented Feb 18, 2019

"Consume a name" doesn't return an <ident-token>. Also, it seems more
clean to avoid css-syntax's tokens if we can.

"Consume a name" doesn't return an <ident-token>. Also, it seems more
clean to avoid tokens completely (if possible).
@tabatkins
Copy link
Member

Ah shoot, I thought it returned an ident token, so I was then grabbing the ident token's value (a string) to continue the algorithm with. ^_^ Def my bad.

@tabatkins tabatkins merged commit 5fc94f1 into w3c:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants