Skip to content

Conversation

@majido
Copy link
Contributor

@majido majido commented Mar 7, 2019

There is no need for state to be a getter rather than a function.

It is simpler to implement and more consistent with animate() for state to also be a function.

@majido majido requested a review from stephenmcgruer March 7, 2019 21:58
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

@majido majido merged commit 6a95854 into w3c:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants