[css-properties-values-api] Require <custom-ident> as component name.#884
Merged
Conversation
Something like this was in the original syntax parsing PR, but it got lost at some point. Resolves w3c#879.
Member
Author
Member
Author
|
Uhm, oops, that doesn't work, hold on. |
Member
Author
|
There we go. |
tabatkins
requested changes
May 7, 2019
Member
tabatkins
left a comment
There was a problem hiding this comment.
Can't match strings against productions, have to do a parse on it to turn it into a CSS value.
Co-Authored-By: andruud <andruud@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something like this was in the original syntax parsing PR, but it got
lost at some point.
Resolves #879.