Adjust spec for KeywordValue to be wrapper for string, add table of properties to StyleValue types. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a minimum, you can just use raw HTML. There might be a nicer way though - @tabatkins? |
| </pre> | ||
|
|
||
| {{KeywordValue}} objects represent {{StyleValue}}s that are keywords. It is simply a wrapper for a string | ||
| and does not check that it contains a valid keyword. |
There was a problem hiding this comment.
Add a note that property setters will enforce keyword validity.
Just write an HTML table. Bikeshed's source format is a subset of Markdown + HTML + some BS-specific stuff, so if it's not covered by vanilla Markdown, it's probably HTML. Use good, semantic markup (thead/tbody, th, col/colgroup if appropriate) and then add |
|
Added some updates and a big partial table for accepted types. |
shans
added a commit
that referenced
this pull request
Jan 26, 2016
Adjust spec for KeywordValue to be wrapper for string, add table of properties to StyleValue types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I actually did this last year and completely forgot!
Keywords are now just a wrapper for a String.
I also started a table for which properties can take which StyleValues, but got stuck with how to make a table in bikeshed. Any advice?