[worklets] Reject with script's error to rethrow #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@bfgeek @hiroshige-g Can you review this? Thanks! |
hiroshige-g
approved these changes
Sep 30, 2019
|
I just noticed this patch is not sufficient. We have to queue a task at the step 4 like the step 3. I'll make a separate PR. |
nhiroki
added a commit
to nhiroki/css-houdini-drafts
that referenced
this pull request
Oct 2, 2019
This is a follow-up patch for w3c#958. A task to reject addModule() should be queued with script's error to rethrow to run on the thread where addModule() is called.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 2, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2
bfgeek
pushed a commit
that referenced
this pull request
Oct 7, 2019
This is a follow-up patch for #958. A task to reject addModule() should be queued with script's error to rethrow to run on the thread where addModule() is called.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 8, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 8, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 8, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 8, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 8, 2019
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 17, 2019
…s error to rethrow if available, a=testonly Automatic update from web-platform-tests Worklet: Reject addModule() with script's error to rethrow if available This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606} -- wpt-commits: 162858b9961ab26dbbe27e07bea2d6e6d10702df wpt-pr: 19462
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Oct 18, 2019
…s error to rethrow if available, a=testonly Automatic update from web-platform-tests Worklet: Reject addModule() with script's error to rethrow if available This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606} -- wpt-commits: 162858b9961ab26dbbe27e07bea2d6e6d10702df wpt-pr: 19462
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 19, 2019
…s error to rethrow if available, a=testonly Automatic update from web-platform-tests Worklet: Reject addModule() with script's error to rethrow if available This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouheichromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org> Commit-Queue: Hiroki Nakagawa <nhirokichromium.org> Cr-Commit-Position: refs/heads/master{#703606} -- wpt-commits: 162858b9961ab26dbbe27e07bea2d6e6d10702df wpt-pr: 19462 UltraBlame original commit: be5a525dc0ae96f3bca68b403b22e4bb3bfc56b0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 19, 2019
…s error to rethrow if available, a=testonly Automatic update from web-platform-tests Worklet: Reject addModule() with script's error to rethrow if available This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouheichromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org> Commit-Queue: Hiroki Nakagawa <nhirokichromium.org> Cr-Commit-Position: refs/heads/master{#703606} -- wpt-commits: 162858b9961ab26dbbe27e07bea2d6e6d10702df wpt-pr: 19462 UltraBlame original commit: be5a525dc0ae96f3bca68b403b22e4bb3bfc56b0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 19, 2019
…s error to rethrow if available, a=testonly Automatic update from web-platform-tests Worklet: Reject addModule() with script's error to rethrow if available This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouheichromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org> Commit-Queue: Hiroki Nakagawa <nhirokichromium.org> Cr-Commit-Position: refs/heads/master{#703606} -- wpt-commits: 162858b9961ab26dbbe27e07bea2d6e6d10702df wpt-pr: 19462 UltraBlame original commit: be5a525dc0ae96f3bca68b403b22e4bb3bfc56b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #509