Emit error for deprecated media features #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f83ef30 to
f115eb9
Compare
|
Should it be a warning, but as warnings are mostly ignored, I can understand why. Could there be another way to fix this duality? |
IMHO, it it should be an error — because the spec says “Authors must not use them”, with a “must”. (If the spec instead said “Authors should not use them”, then I would think a warning would be the right choice.) |
When the CSS3 profile is selected, this change causes an error to be emitted for the following deprecated media features: device-aspect-ratio, device-height, device-width — as well as for their corresponding min- and max- prefixed versions. https://www.w3.org/TR/2017/CR-mediaqueries-4-20170905/#mf-deprecated states: > The following media features are deprecated. They kept for backward > compatibility, but are not appropriate for newly written style sheets. > Authors must not use them. Otherwise, without this change, no messages (not even warnings) are reported for the (mis)use of those media features.
f115eb9 to
514cb23
Compare
|
Rebased. I still do think this should be an error, not a warning — for the reason in #240 (comment) — because the spec says “Authors must not use them”, with a “must”. (If the spec instead said “Authors should not use them”, then I would think a warning would be the right choice.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CSS3 profile is selected, this change causes an error to be emitted for the following deprecated media features: device-aspect-ratio, device-height, device-width — as well as for their corresponding min- and max- prefixed versions.
https://www.w3.org/TR/2017/CR-mediaqueries-4-20170905/#mf-deprecated states:
Otherwise, without this change, no messages (not even warnings) are reported for the (mis)use of those media features.