Instanceof Check Before Cast #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, however the issue is that the old inheritance tree is no longer the right one, and it is part of the few properties that have not been fixed properly. |
ylafon
added a commit
that referenced
this pull request
Nov 10, 2022
As SVGTinyStyle inherit from CSS3 and as image-rendering is present in CSS3 it is better to define it in Css3Style, and move all the casts from SVGBasicStyle to Css3Style
|
b7153af fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it on the following example:
Without setting the ApplContext to
css3svg, theimage-rendring: auto;property is a CSS3Style. That will be tried to be cast to SVGBasicStyle without even checking if that's possible. This caused ClassCastException.Can be recreated on the online validator too, if you set the options from CSS3 + SVG to only CSS3.