Refine message for unrecognized at-rule #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the following error message: > Sorry, the at-rule %s is not implemented. ...to this: > Unrecognized at-rule %s
|
Will do the french translation as well. |
|
I'll do the Chinese translation after finding out a good Chinese name for "at-rule". (The current one doesn't look good enough to me.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following error message:
...to this:
We don’t need the word “Sorry” in there, and the “is not implemented” part
makes users wonder if it means the at-rule isn’t implemented in browsers.
So let’s just make it “Unrecognized” — which covers both the cases of a valid
at-rule like @supports, which the CSS Validator doesn’t yet recognize because
no support for it has been added to the validator yet, and also the case of a
completely invalid at-rule like @key-frames, which is typo for @Keyframes.