Skip to content

[css-fonts] Grammar of <feature-value-name> #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimonSapin opened this issue Feb 2, 2017 · 3 comments
Closed

[css-fonts] Grammar of <feature-value-name> #1000

SimonSapin opened this issue Feb 2, 2017 · 3 comments
Assignees
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-4 Current Work

Comments

@SimonSapin
Copy link
Contributor

The grammar for the value of font-variant-alternates https://drafts.csswg.org/css-fonts/#propdef-font-variant-alternates links its values to their respective definitions, for example stylistic(<feature-value-name>) is i link to https://drafts.csswg.org/css-fonts/#stylistic.

However once we’re there, stylistic(<feature-value-name>) is repeated but without any link. I couldn’t find the definition for the grammar of <feature-value-name>. Based on reading other sections of the spec I think it’s supposed to be a single identifier. There should be a definition (maybe <feature-value-name> = <custom-ident> ? https://drafts.csswg.org/css-values/#custom-idents) and it should be linked every time <feature-value-name> is used elsewhere, like for example in https://drafts.csswg.org/css-fonts/#stylistic.

@css-meeting-bot
Copy link
Member

The Working Group just discussed [css-fonts] Grammar of <feature-value-name>.

The full IRC log of that discussion <dael> Topic: [css-fonts] Grammar of <feature-value-name>
<dael> github: https://github.com//issues/1000
<dael> Chris: No one has commented since Feb.
<dael> Chris: Part of the issue is because this is pre-bikeshed spec we don't have a good link into grammar part of CSS.
<dael> Chris: Is Simon on the call?
<dael> astearns: Is this strictly editorial or is there a problem with grammar because link isn't set up correct.
<dael> Chris: Grammar problem. Is this a single identifier or is it not.
<dael> Chris: I would be okay getting back to Simon asking for more details on what's the issue.
<dael> astearns: Okay. Anyone else have any...can anyone else bring clarity to this?
<dael> astearns: Let's tag Simon and get more information.
<dael> Chris: Thanks very much. I yield the floor.
<dael> astearns: Thanks for going through this to make sure fonts has a good DoC

@SimonSapin
Copy link
Contributor Author

Yes, this is editorial. Since filing this issue https://drafts.csswg.org/css-fonts/#propdef-font-variant-alternates has changed and <feature-value-name> now is linked. It goes to https://drafts.csswg.org/css-fonts/#typedef-feature-value-name

The identifiers used within feature value definitions define <feature-value-name>s and follow the rules of CSS user identifiers and are case-sensitive.

… which seems to be a convoluted way of saying <feature-value-name> = <custom-ident>. Let’s call it good enough.

@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Jan 10, 2018
@svgeesus svgeesus removed the Agenda+ label Feb 1, 2018
@svgeesus svgeesus self-assigned this May 1, 2018
@svgeesus
Copy link
Contributor

svgeesus commented May 1, 2018

Re-opening with an edits needed label and re-assigning to Fonts 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-4 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants