-
Notifications
You must be signed in to change notification settings - Fork 707
[css-text-4] Rename trim-auto
to trim-both
#10161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree it's better naming |
|
@frivoal Yeah, but |
When I suggested (#4246 (comment)) renaming |
This is just an editorial suggestion related on renaming
to
(I think this is more natural:
With this table, it is much understandable that |
The other advantage of the name I'm not sure if |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> fantasai: text-spacing has a bunch of values.<TabAtkins> fantasai: as we've tweaked 'normal' and the proeprty syntax, we've gotten to a place where we have "normal" being a baseline behavior where we allow spacing at start/end of th eline, but collapse within the line <TabAtkins> fantasai: And we have trim-start, trim-all, space-all, space-first <fantasai> https://github.com//issues/10161#issuecomment-2033649072 <TabAtkins> fantasai: There's also trim-auto which is baseically trim-start + trim-end + the baseline "trim in the middle" behavior <TabAtkins> fantasai: It makes sense to rename to trim-both, then <TabAtkins> fantasai: Murakami-san seems to align on that <TabAtkins> fantasai: I believe this is the one keyword not yet shipped by Chrome, so it should still be fixable <TabAtkins> proposed resolution: rename trim-auto to trim-both <TabAtkins> RESOLVED: rename trim-auto to trim-both |
Edited in, thanks @MurakamiShinyu for all of your comments and suggestions! |
Automatic update from web-platform-tests Rename trim-auto to trim-both See w3c/csswg-drafts#10161 -- wpt-commits: 448fee1581cff98e9052a3d5d5640fbb7319a530 wpt-pr: 46531
Automatic update from web-platform-tests Rename trim-auto to trim-both See w3c/csswg-drafts#10161 -- wpt-commits: 448fee1581cff98e9052a3d5d5640fbb7319a530 wpt-pr: 46531
Given the current set of values, and the fact that
normal
trims adjacent pairs andtrim-start
indicates trimming the start and adjacent pairs, I thinktrim-both
might be a better name fortrim-auto
which trims the start, adjacent pairs, and end. Thoughts? CC @MurakamiShinyu @frivoal @kojiishi @myakuraThe text was updated successfully, but these errors were encountered: