Skip to content

[css-view-transitions-1] What is the size of the group pseudo for the root element? #10177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nt1m opened this issue Apr 5, 2024 · 4 comments · Fixed by #10181
Closed

[css-view-transitions-1] What is the size of the group pseudo for the root element? #10177

nt1m opened this issue Apr 5, 2024 · 4 comments · Fixed by #10181

Comments

@nt1m
Copy link
Member

nt1m commented Apr 5, 2024

From @mattwoodrow from investigating https://bugs.webkit.org/show_bug.cgi?id=272186:

Chrome seems to be setting the size of their ::view-transition-group element to that of the snapshot containing block. That seems wrong, but visually what you’d expect to happen.

Capture the image algorithm has a special case for sizing the image when capturing the root, I suspect Update pseudo-element styles should have the equivalent wording for setting the width/height style properties.

@nt1m
Copy link
Member Author

nt1m commented Apr 5, 2024

@noamr @khushalsagar @vmpstr

@noamr
Copy link
Collaborator

noamr commented Apr 5, 2024

Sounds reasonable to me, will wait for Vlad/Khush to confirm. Happy to make the edit.

@khushalsagar
Copy link
Member

That seems wrong, but visually what you’d expect to happen.

Just to confirm, the error is that we're using the border-box for the document element here. Instead it should be the snapshot containing block size similar to when we do this for the old DOM here.

SGTM. Thanks for spotting this!

noamr added a commit to noamr/csswg-drafts that referenced this issue Apr 8, 2024
This aligns with current behavior, but was overlooked in the spec.

Closes w3c#10177
@mattwoodrow
Copy link
Contributor

Just to confirm, the error is that we're using the border-box for the document element here. Instead it should be the snapshot containing block size similar to when we do this for the old DOM here.

Yes, exactly. Thank you!

khushalsagar added a commit that referenced this issue Apr 9, 2024
…10181)

* [css-view-transitions-1] Use snapshot containing block for new root

This aligns with current behavior, but was overlooked in the spec.

Closes #10177

* Update css-view-transitions-1/Overview.bs

---------

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants