-
Notifications
You must be signed in to change notification settings - Fork 715
[css-inline] Disallow auto
in text-box
shorthand
#10748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(waiting for more responses before trying an async resolution) |
I'm neutral, I'd like to defer to better English speakers. Other values such as |
The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment. Proposed Resolution: Drop the |
RESOLVED: Drop the |
https://bugs.webkit.org/show_bug.cgi?id=279400 rdar://135616944 Reviewed by NOBODY (OOPS!). `text-box: auto` means `text-box: trim-both` which is confusing. Stop allowing `auto` within the shorthand. All the combinations with `auto` already have alternative representations without it. CSSWG resolution: w3c/csswg-drafts#10748 (comment) * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-valid.html: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeTextBoxShorthand):
I'm going to kick this back onto the agenda for three reasons:
|
Re 2. I'm OK just disallowing |
I guess there are multiple reasons to want to improve I'm fine with the proposal, but if controversial, it's a bit scary that we may keep hearing other values such as How about: |
The CSS Working Group just discussed
The full IRC log of that discussion<matthieud> fantasai: disallow allow in text-box shorthand because it comes for text-box-edge property<matthieud> fantasai: because `text-box: auto` is confusing <matthieud> `text-box: normal` is the same and clearer <fantasai> s/normal/trim-both/ <matthieud> we should revert the previous resolution and allow all combination <matthieud> fantasai: we should at least allow `auto` to be combined <fantasai> text-box: <'text-box-trim'> || <'text-box-edge'> <matthieud> RESOLVED: revert the previous resolution : allow all combinations for `text-box` <fantasai> https://github.com//issues/10748#issuecomment-2339570832 <matthieud> fantasai: when it is appropriate to disallow a longhand value in a shorthand ? <matthieud> fantasai: could introduce ambiguity in parsing, could be blocking for the future, how readable is it <fserb> q+ <matthieud> fantasai: we should have a very clear reason when we disallow a longhand value in shorthand <matthieud> fantasai: careful about `auto` keyword also <Rossen16> ack fserb <matthieud> fserb: would this be a principle ? <matthieud> fantasai: yes <florian> q? <matthieud> fantasai: do we anticipate having a keyword `auto` for `text-box` (not the one from `text-box-edge`) ? <astearns> something to add to https://wiki.csswg.org/spec#coordination-between-specifications? <matthieud> fantasai: this would be a good reason to disallow <matthieud> florian: no reason in this specific case <matthieud> florian: should we upstream that to the "tag design principals" document ? <fantasai> https://wiki.csswg.org/ideas/principles |
text-box: auto
is quite confusing, because it meanstext-box: trim-both
, nottext-box: normal
.I suggest we just stop allowing
auto
within the shorthand. All the combinations withauto
already have alternative representations without it.cc @kojiishi @fantasai
The text was updated successfully, but these errors were encountered: