-
Notifications
You must be signed in to change notification settings - Fork 715
[css-view-transition-2] Should non-default view-transition-group
act like contain
?
#10780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The reason we added Can you expand on what you're proposing with "nearest and would also act as contain". I'm guessing And not sure how |
Let's say this is the hierarchy html { view-transition-name: root }
parent { view-transition-name: parent; view-transition-group: nearest; }
child { view-transition-name: child; } Based on the current spec wording, the I wanted to either re-affirm the current spec wording ( |
I thought child in this case would be under
Maybe we need a combo keyword, since in this situation you want parent to be |
Oops, yes.
Yea, I think perhaps we should make it so that |
OK, I see 3 options here:
|
I still think it's somewhat confusing, plus there may be a scenario for an element to both a containing parent and a contained child. |
We can still allow that, meaning
I wonder if we need this contain keyword at all TBH. This kind of containment can be easily achieved through combinator selectors and perhaps it's better to keep it there rather than create this vt-specific mini-cascade. |
Well, at the end of the day |
Out of the options in #10780 (comment), my preference would be 3). Not a fan of 2) since it makes it impossible to use nearest/custom-ident without also forcing contain. |
Also added option (4). |
This was the proposal we resolved on: #10334 (comment) Just read though the thread (quickly, so might have missed something). I think what you want (?) is something like
The property name hooks into the |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> astearns: elika was thinking this was alreayd resolved<TabAtkins> fantasai: when we resolved to adopt the v-t-group, there was a proposal that covered this case, which describes the features exactly as specified here <TabAtkins> noamr: I thought so, but figured it wasn't clear enough <TabAtkins> fantasai: i'll drop a link to the proposal we adopted <khush> q+ <TabAtkins> fantasai: the values in the proposal we resolved defined the values in the way noam is discussing here <TabAtkins> noamr: yeah this detail was in the conversation, but not explicitly in the resolution <astearns> ack khush <TabAtkins> khush: the use-case that was raised in the issue, it wasn't clear how we resolved applied to it, let me understand <TabAtkins> khush: right now v-t-group does two things, it parents to something, and says your subtree is parented to you <vmpstr> q+ <fantasai> �the proposal as expressed in the issue <TabAtkins> khush: you can't say both at the same time, so the proposal is to combine them and have them imply both? <fantasai> https://github.com//issues/10334#issuecomment-2165649094 <TabAtkins> noamr: option 2, nearest and custom-ident implicitly mean contain too <vmpstr> q- <vmpstr> +1 <TabAtkins> fantasai: yes, that was in the description of the values <TabAtkins> khush: i'm not a fan of it; i don't see why the nearest keyword has to implly it, rather than just allowing both keywords to be specified together if you want that <astearns> q+ fantasai <TabAtkins> khush: i think there are cases where you'd use nearest without implying you want your subtree too <vmpstr> q+ <astearns> ack fantasai <TabAtkins> fantasai: you could, but I think it's more likely you want capture. <vmpstr> q- <vmpstr> +1 <noamr> +1 <TabAtkins> fantasai: if you want to escape the capture you can use a name on the descendant; it doesn't *trap* them, it just contains by default <flackr> +1 <TabAtkins> khush: ? <TabAtkins> fantasai: if you come back with use-cases and decide that by default you don't want to capture, we could revisit, i just think by default it's the right behavior <TabAtkins> khush: the thing that wasn't clear to me is that you could use a custom-ident on a descendant to escape, ok <fantasai> https://github.com//issues/10334#issuecomment-2165649094 <noamr> nearest and <custom-ident> implicitly also mean contain <fantasai> PROPOSED: all values other than normal implicitly contain <TabAtkins> astearns: any objections to this proposal? <TabAtkins> RESOLVED: all values other than 'normal' implicitly contain |
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363033}
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363033}
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363033}
… containment, a=testonly Automatic update from web-platform-tests CSS view transitions: non-normal implies containment See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363033} -- wpt-commits: 37b6a4dcb6d9dd2b7cbdaa8c3efed077879a9bdd wpt-pr: 48421
… containment, a=testonly Automatic update from web-platform-tests CSS view transitions: non-normal implies containment See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Cr-Commit-Position: refs/heads/main{#1363033} -- wpt-commits: 37b6a4dcb6d9dd2b7cbdaa8c3efed077879a9bdd wpt-pr: 48421 UltraBlame original commit: 0d223b3282344d327f8ecebd74307d0a28d02e16
… containment, a=testonly Automatic update from web-platform-tests CSS view transitions: non-normal implies containment See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Cr-Commit-Position: refs/heads/main{#1363033} -- wpt-commits: 37b6a4dcb6d9dd2b7cbdaa8c3efed077879a9bdd wpt-pr: 48421 UltraBlame original commit: 0d223b3282344d327f8ecebd74307d0a28d02e16
… containment, a=testonly Automatic update from web-platform-tests CSS view transitions: non-normal implies containment See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363033} -- wpt-commits: 37b6a4dcb6d9dd2b7cbdaa8c3efed077879a9bdd wpt-pr: 48421
… containment, a=testonly Automatic update from web-platform-tests CSS view transitions: non-normal implies containment See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Cr-Commit-Position: refs/heads/main{#1363033} -- wpt-commits: 37b6a4dcb6d9dd2b7cbdaa8c3efed077879a9bdd wpt-pr: 48421 UltraBlame original commit: 0d223b3282344d327f8ecebd74307d0a28d02e16
Right now
view-transition-group
is a bit inconsistent, because:nearest
and<custom-ident>
refer to nesting from the descendant's point of viewcontain
refers to nesting from the ancestor's point of view.Perhaps it would make more sense that
nearest
and<custom-ident>
would also act ascontain
? I think the discussion in the WG here was sort of saying it but the resolution was ambiguous.If we do that, what happens when there's an invalid
<custom-ident>
?cc @vmpstr @khushalsagar @fantasai, also @ydaniv that raised this concern in the last VT breakout.
The text was updated successfully, but these errors were encountered: