-
Notifications
You must be signed in to change notification settings - Fork 707
[css-conditional] @container scroll-state(snapped) and snapchanged vs snapchanging #10784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
css-conditional-5
Current Work
Comments
The CSS Working Group just discussed
The full IRC log of that discussion<kbabbitt> futhark: this is an issue about scroll state snapped<kbabbitt> ...question of whether state queries should match at the same time the snap changes or also including snap changing <kbabbitt> ...think it makes sense to maek state query change while you're scorlling <kbabbitt> ...got some feedback from ? that he thought you might want to have 2 separate queries <TabAtkins> q+ <kbabbitt> ...one that changes with snap query and one that's only matching after ? <flackr> q+ <kbabbitt> ...just looking for input, if someone thinks current behavior matching snap changing is good or if there are any other suggestions <miriam> q+ <Rossen4> ack TabAtkins <kbabbitt> TabAtkins: I agree that if we continue to keep just one query, having it match the snapchanging event so you'll start succeeding on the element that is becoming snapped is right <kbabbitt> ...Adam's argument about having 2 is intriguing, would like to see an example <kbabbitt> ...could easily be convinecd that it's a good thing to do <kbabbitt> futhark: happy to resolve on matching snapchanging <Rossen4> ack flackr <kbabbitt> flackr: also agree that snapchanging is the right first step would like to see use cases for snapchanged <flackr> https://github.com//issues/10838 <kbabbitt> ...also wanted to point out open issue about what snapchanging targets <kbabbitt> ...10838 <kbabbitt> ...where I think, Adam has potentially requested a third possible query <kbabbitt> futhark <kbabbitt> futhark: just to correct a bit about what I have implemented so far <kbabbitt> ...checking oth snapchanged and snapchanging <kbabbitt> ...in case there's snapchanged that happened without snapchanging <kbabbitt> flackr: that is not supposed to happen <Rossen4> ack miriam <kbabbitt> miriam: I think I basically agree with TabAtkins and flackr <kbabbitt> ...to clarify, snapchanging is inclusive of ? changed <kbabbitt> ...we're not saying it matches only when it's changing but also when it has changed <kbabbitt> ...agree we're starting in the right way <kbabbitt> Rossen4: other opinions? <kbabbitt> futhark: currently snap... if that's a bad name, if we decide to add the scroll changed / snap changed later... [?] <kbabbitt> flackr: are there other patterns we could follow <kbabbitt> TabAtkins: I don't think we have precedent yet <kbabbitt> miriam: I think snap is nice for the default <kbabbitt> ...we can figure something else out for the other <kbabbitt> futhark: we can just resolve that snapped matches snapchanging <kbabbitt> Rossen4: other comments? <kbabbitt> RESOLVED: snapped matches snapchanging <TabAtkins> ScribeNick: TabAtkins |
lilles
added a commit
to lilles/csswg-drafts
that referenced
this issue
Oct 14, 2024
Edit to clarify the resolution[1] in w3c#10784 that scroll-state(snapped) matches the snap target for scrollsnapchanging, not scrollsnapchanged. That is, the snapped query changes evaluation during a scroll operation. [1] w3c#10784 (comment)
svgeesus
pushed a commit
that referenced
this issue
Oct 14, 2024
Edit to clarify the resolution[1] in #10784 that scroll-state(snapped) matches the snap target for scrollsnapchanging, not scrollsnapchanged. That is, the snapped query changes evaluation during a scroll operation. [1] #10784 (comment)
PR landed. There is also a test: https://wpt.fyi/results/css/css-conditional/container-queries/scroll-state-snapped-snap-changing.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a few options for when the snap target changes for scroll-state(snapped: ...) queries
snapchanged
eventsnapchanging
eventIf we only have a single feature, I assume (2) would be the preferred behavior?
If we decide to have two features, what should their names be?
snapped
andsnapping
?The text was updated successfully, but these errors were encountered: