-
Notifications
You must be signed in to change notification settings - Fork 708
[css-grid-3] Add a keyword for setting masonry-slack
to infinity
#10883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Ooh, thanks for the references! Yeah, we definitely should make this easy, then. I agree that using the keyword |
tabatkins
added a commit
that referenced
this issue
Sep 20, 2024
Okay, added. @fantasai and I are of the opinion that this is probably requested so often because none of the masonry libraries have a concept of slack at all (which is so weird to us), but still, there are use-cases that might reasonably demand it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would have preferred to discuss this in #10232, but I was on vacation. So as Alan mentioned during the call, I'm filing this as a separate issue.
My point is that an infinity value for
masonry-slack
, unlike any other value, provides a stable layout that doesn't mess with the order when items change their size.This is also an option that is exposed by the most widely used masonry frameworks. Just with a quick search I could find:
And it's very telling that authors are actively requesting it, as @desandro mentioned in #10233 (comment)
Then, sure, authors could use
masonry-slack: calc(1px / 0)
. But this has some problems:calc(infinity * 1px)
, or other calculations)So I do think we need a keyword for this. We could go with
masonry-slack: infinite
(a laanimation-iteration-count
), or maybe think a name that is more descriptive of the provided behavior, I don't mind.The text was updated successfully, but these errors were encountered: