-
Notifications
You must be signed in to change notification settings - Fork 708
[css-grid] Decide on a name for item-slack
#10884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm liking I'm not fond of "slack" because as a non-native English speaker that's a word that I learned considerably later than the others. "strictness" and "sensitivity" can seem to imply that a higher value will choose the track by comparing the running positions more strictly, while it's actually the opposite. |
Current spec proposal is |
masonry-slack
item-slack
I really like |
I wonder whether more information about what gets the slack would improve the property name. I see that this was suggested in the earlier issue, using
|
There is Other funny suggestions : |
The name definitely needs to at least imply that the property pertains to how items are fit into the layout -- specifically, the concept of "fitting" a thing in. Things like "placement" don't, and absent any other qualifiers, words like "tolerance" and "threshold" are way too vague. (What is it the threshold of?) As far as the two-word suggestions go, The word "slack" conveys looseness, whereas it seems like higher values would cause items to be fit into the layout in more tightly compressed arrangements. So "more slack" leads to a tighter, not looser, fit? Seems backwards. WebKit's explainer describes the property as inviting the browser to "cram" extra items into tight spaces. Maybe |
I think the focus needs to be on describing the extra space and not the result of that extra space to keep the property semantically distinct. Just to sum up my understanding: In flexbox, a higher number will allow a larger element to be compacted into the current row before the algorithm moves to the next. If in the current row there is In grid, a higher number will allow to re-equalize columns in a specific direction. If column 1 has Please correct me if I'm wrong in my current understanding. But if all of this is right, |
The CSS Working Group just discussed
The full IRC log of that discussion<kbabbitt> oriol: we have this property item-slack<kbabbitt> ... what it does is allow diverging from sorting items into shortest track <kbabbitt> .. with tracks filled to a similar amount it allows following source order instead of shortest <kbabbitt> .. value of 0 means strictly shortest track <kbabbitt> ... value of infinity means strictly source order <kbabbitt> ... this is named 'item-slack' in spec <kbabbitt> ... but we didn't resolve on that name <kbabbitt> ... not fond of "slack" as non-native Engish speaker <kbabbitt> ... there were also some other ideas like strictness, or ?? <kbabbitt> ... they seem to imply a higher value will implyu more strictness <kbabbitt> ... where it's the opposite <astearns> s/??/sensitivity/ <kbabbitt> ... other ideas were threshold, adjust, skip <kbabbitt> ... I propose 'tolerance' <kbabbitt> ... which some people were recommending recently <bkardell> s/implyu/imply <dbaron> We can always change the property values to match the name. <kbabbitt> ... when I proposed this it was with masonry prefix <kbabbitt> ... now that it could be item tolerance, could be more confusing of how you're adding tolerance <kbabbitt> ... astearns proposed 'item-fit' <kbabbitt> ... someone also suggested "cram" <jensimmons> q+ <kbabbitt> ... but people liked the word tolerance <kbabbitt> fantasai: cram doesn't work for all the cases we're talking about <kbabbitt> TabAtkins: can't imply squeezing or stretching <kbabbitt> ... can be used for either <astearns> ack jensimmons <fantasai> florian: "fuzz"? <kbabbitt> jensimmons: let's rename it <kbabbitt> ... I like tolerance too <TabAtkins> I'm okay with 'tolerance' <kbabbitt> ... it is true that it is confusing by itself <kbabbitt> ... item-fit-tolerance is good but long <TabAtkins> i don't super like any of the shorter words than tolerance <kbabbitt> ... would be all for replacing slack with fit-tolerance <kbabbitt> TabAtkins: also a fan of tolerance <kbabbitt> astearns: everyone ok with adding 'fit'? <kbabbitt> fantasai: don't love it but don't have better suggestion <kbabbitt> astearns: we're not tolerating the item <kbabbitt> TabAtkins: all the item properties are about placing item, so item-tolerance would also be about placing the item <kbabbitt> ... think it already suggests roughly what we're aiming at <kizu> +1 to tolerance as well <kbabbitt> astearns: item-fit-tolerance was my best name <kbabbitt> TabAtkins: I'm always looking out for property name lengths <kbabbitt> dholbert: item-fit reminds me of object-fit which is unrelated <kbabbitt> ... that slight overlap is confusing <kbabbitt> dbaron: don't reject names because they don't go with values <kbabbitt> ... can always change values to go with names <kbabbitt> TabAtkins: here the values are lengths not keywords <kbabbitt> fantasai: what if we rename item-flow to flow <kbabbitt> ... then it would be flow-tolerance, flow-direction, ... <kbabbitt> TabAtkins: doesn't that land us against flow layout module that describes block? <ethanjv> I like flow <kbabbitt> fantasai: besides display keyword is awkward <kbabbitt> ... otherwise work really well <ethanjv> https://drafts.csswg.org/css-grid-3/#flow-control <kbabbitt> TabAtkins: can we look at item properties real quick? <kbabbitt> fantasai: replace 'item' prefix with 'flow' <kbabbitt> ... then 'item-flow' becomes 'flow' <kbabbitt> TabAtkins: means we can't have a shorthand <kbabbitt> fantasai: item-flow -> flow is the shorthand <kbabbitt> kbabbitt: "flow-pack"? <kbabbitt> fantasai: yes <kbabbitt> astearns: don't want to resolve on this change right away <kbabbitt> astearns: Proposed: rename item-slack to item-tolerance <fantasai> SUMMARY: Contemplate replacing 'item-' with 'flow-' <kbabbitt> bkardell: it's very difficult for people looking in to understand stability of our decisions <kbabbitt> ... we should say, as a currently best working answer but probably to be re-bikeshedded later <kbabbitt> astearns: that applies to all our resolutions <kbabbitt> bkardell: should be more specific here since it's being cited in intents to ship <oriol> Hard to hear Brian <kbabbitt> TabAtkins: this one is pretty explicitly tentative <kbabbitt> bkardell: can we put the word tenative in the resolution? <kbabbitt> florian: all our decisions can be revisited, when we know they will be, dont print your book yet <kbabbitt> astearns: Proposed: rename item-slack to item-tolerance ... for now. <kbabbitt> astearns: objections? <kbabbitt> RESOLVED: rename item-slack to item-tolerance ... for now. <kurt> The spec uses the word "threshold" - The item-slack property specifies what the threshold is for considering tracks to be “the same height”, causing them to fill in order. |
Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c
Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062}
Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062}
Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062}
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almahermicrosoft.com> Reviewed-by: Ethan Jimenez <ethavarmicrosoft.com> Commit-Queue: Ethan Jimenez <ethavarmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926 UltraBlame original commit: 4cd62daca801bbacc62f965c136a5a6948b94a92
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almahermicrosoft.com> Reviewed-by: Ethan Jimenez <ethavarmicrosoft.com> Commit-Queue: Ethan Jimenez <ethavarmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926 UltraBlame original commit: 4cd62daca801bbacc62f965c136a5a6948b94a92
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almahermicrosoft.com> Reviewed-by: Ethan Jimenez <ethavarmicrosoft.com> Commit-Queue: Ethan Jimenez <ethavarmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926 UltraBlame original commit: 4cd62daca801bbacc62f965c136a5a6948b94a92
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926
…y to item-tolerance, a=testonly Automatic update from web-platform-tests [Masonry] Renaming masonry-slack property to item-tolerance Update code to use "item-tolerance" instead of "masonry-slack" in order to match the results of the discussion here: w3c/csswg-drafts#10884 (comment). Bug: 343257585 Change-Id: I1f4b0c6ead16365e8d819218c3ffaf08747b613c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398266 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1445062} -- wpt-commits: e3ea1bbccb0bf683723b48fa0c3b43a27b1a8598 wpt-pr: 51926
#9328 (comment) didn't resolve on the name for this property.
In the spec it has been tentatively added as
masonry-slack
: https://drafts.csswg.org/css-grid-3/#masonry-slackOther ideas from #9328 are
masonry-threshold
,masonry-placement-threshold
,masonry-strictness
,masonry-adjust
,masonry-skip
,masonry-sensitivity
.The text was updated successfully, but these errors were encountered: