Skip to content

[css-multicol-1] column-rule-style: {none | hidden} forcing column-rule-width to 0 #11090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbabbitt opened this issue Oct 25, 2024 · 6 comments

Comments

@kbabbitt
Copy link
Collaborator

While working on draft text for gap decorations, I noticed a minor inconsistency in the existing text for column rules in css-multicol-1.

Section 4.4 states that the computed value for column-rule-width is:

absolute length, snapped as a border width; 0 if the column rule style is none or hidden

However, Section 4.3, defining column-rule-style, states:

The none value forces the computed value of column-rule-width to be 0.

...and makes no mention of hidden.

Blink, Webkit, and Gecko all agree that column-rule-style: hidden results in the computed value of column-rule-width being set to 0. Test page: https://codepen.io/kevinbcmu/pen/qBeVyme

Should we update the text for column-rule-width to reflect this?

@kbabbitt kbabbitt added the css-multicol-1 Current Work label Oct 25, 2024
@kbabbitt
Copy link
Collaborator Author

kbabbitt commented Nov 4, 2024

Agenda+ to propose making the text consistently match what's shipped.

@fantasai
Copy link
Collaborator

Sounds like this would make it both match what's shipped and also match how borders work, so +1 from me and it seems obvious enough of a bugfix that I think an async resolution would be reasonable.

@fantasai fantasai added the Async Resolution: Proposed Candidate for auto-resolve with stated time limit label Nov 12, 2024
@rachelandrew
Copy link
Contributor

+1 from me.

@astearns
Copy link
Member

Does this need a resolution? The definition of hidden says that it's the same as none in https://www.w3.org/TR/css-backgrounds-3/#typedef-line-style

Perhaps it's merely editorial to make this explicit in the prose for column-rule-style

@astearns astearns removed the Async Resolution: Proposed Candidate for auto-resolve with stated time limit label Nov 20, 2024
kbabbitt added a commit to kbabbitt/csswg-drafts that referenced this issue Nov 22, 2024
@kbabbitt
Copy link
Collaborator Author

Taking this as an editorial change works for me if the spec editors are happy with that outcome.
Created a PR here: #11262

@kbabbitt
Copy link
Collaborator Author

Thanks @rachelandrew! Closing as editorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants