-
Notifications
You must be signed in to change notification settings - Fork 707
[css-borders-4] naming of the "not curved" (90deg convex) keyword for corner-shape
#11607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
corner-shape
corner-shape
corner-shape
corner-shape
I agree that using a different keyword than |
Definitely agreed a Going to throw
Wouldn't this shape also be the initial value: #11623 |
To me a potentially confusions with "straight":
Why "square":
|
I'm OK with |
I'd also vote for
I think the keywords distinguish the shape clearly enough from a notch shape. And I also believe, Sebastian |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> noamr: right now this value is named "straight", but i dont like it<TabAtkins> noamr: this is when we treat it as a non-rounded rect <TabAtkins> noamr: other proposals are "square" or "none" <TabAtkins> noamr: or "rect" <TabAtkins> noamr: i think in the issue consensus was for "square" <TabAtkins> astearns: and Simon prefers square <fantasai> TabAtkins: Prefer square to straight. Straight sounds like it means bevel. <TabAtkins> astearns: any concerns over choosing square? <fantasai> RESOLVED: Use square for opposite of notch |
See resolution: w3c/csswg-drafts#11607 (comment) Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 R=fs@opera.com
See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427}
See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427}
See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427}
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fsopera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Fredrik Söderquist <fsopera.com> Cr-Commit-Position: refs/heads/main{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789 UltraBlame original commit: 0ade8ec792c25737a00e0f89e049851972d878dd
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fsopera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Fredrik Söderquist <fsopera.com> Cr-Commit-Position: refs/heads/main{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789 UltraBlame original commit: 0ade8ec792c25737a00e0f89e049851972d878dd
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fsopera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Fredrik Söderquist <fsopera.com> Cr-Commit-Position: refs/heads/main{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789 UltraBlame original commit: 0ade8ec792c25737a00e0f89e049851972d878dd
… a=testonly Automatic update from web-platform-tests Rename corner-shape: straight to square See resolution: w3c/csswg-drafts#11607 (comment) R=fs@opera.com Bug: 407751758 Change-Id: Ieadd0d1915c0965f484d5a93262fc76634382313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1441427} -- wpt-commits: 7f29264e2ae16d05f72faba0b1538e6eb3dd52aa wpt-pr: 51789
Backend CL: https://chromium-review.googlesource.com/c/chromium/src/+/6421727 CSSWG resolution: w3c/csswg-drafts#11607 (comment) Bug: 402346406 Change-Id: I809b190ca383acb42b4adf88d3a8ca53f30368d7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6444664 Reviewed-by: Changhao Han <changhaohan@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org>
Following up on #10993
When the corner shape is a fully convex angle (as in, it's not curved at all,
superellipse(infinity)
), we resolved on referring to it asnone
.I think a better name for this is
straight
. It's not that the corner has no shape, the corner has a straight shape.I put it as
straight
in the draft but we can resolve on this separately if we are ok with it, bring it back tonone
, or come up with something different.This keyword is important for animating
corner-shape
.The text was updated successfully, but these errors were encountered: