-
Notifications
You must be signed in to change notification settings - Fork 707
[css-grid] syntax errors in examples #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose it's usually better to link to the current Editor's draft then to the published snapshot, since the spec changes constanly and even the numbering of the examples is now different (e.g. the old Example 1 is now Example 3). But at least some of the errors you mentioned are still in place. In the example 43 (Example 41 in the current ED), I guess the point of these |
I personally would simple change The intention of writing this issue was basically that all stuff from the examples that looks like code can be copy-pasted into a real CSS. That's all. I personally use the code as examples for my CSS parser to see that he gets everything right. |
If the goal is to enable copy-paste the examples for testing, the actual code to create such grid container (e.g. |
I personally don't think so - there are so many specs out there that it is hard to read all of them in depth - therefore having working examples as a basis would imho be a good idea. |
This closes issue w3c#1166.
I agree it'd be nice to fix the examples, so just in case people copy&paste them we avoid weird confusions. |
This should be fixed now by #1181. |
Spec version: hhttps://www.w3.org/TR/2017/CR-css-grid-1-20170209/
Example 1 is missing one closing bracket (2. bullet point, at
@media print {
)Example 2 uses the
→
character - what's the purpose?Example 31 is missing the closing comment after
Equivalent to grid-area: 2 / 3;
Example 43 uses
…
instead of CSS commentThanks and keep up the good work!
The text was updated successfully, but these errors were encountered: