-
Notifications
You must be signed in to change notification settings - Fork 707
[css-overflow-5] ::scroll-marker should determine inherited interactivity from ::scroll-marker-group #11746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If actually inheriting from the scroll marker group is difficult, we could disallow |
In the same spirit, it may be worth considering |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> flackr: the a11y guidelines for carousel recommend inerting content that's not on screen<TabAtkins> flackr: but if you inert the element that establishes the smarker, th emarker appears in a different spot <TabAtkins> flackr: we think the interactivity of the scroll marker shoulod be based on the interactivey of the scroll-marker-group, which is based on the scroll container <TabAtkins> flackr: currently authors *could* work aorund this by manually un-inerting with 'interactivity', but it feels like a hack. we should do this implicitly <TabAtkins> +1 <TabAtkins> astearns: so resolution is interactivity of ::scroll-marker is based on interactivity of ::scroll-marker-group <TabAtkins> astearns: objections? <TabAtkins> RESOLVED: interactivity of ::scroll-marker is based on interactivity of ::scroll-marker-group <TabAtkins> fantasai: there's a comment in the issue about visibility too <TabAtkins> flackr: i'm open to doing this with more properties, but maybe we take those as separate resolutions <fantasai> TabAtkins: visibility also doesn't have same issue as interactivity, no a11y recommendations <fantasai> TabAtkins: if doing visibility it's up to you to manage <TabAtkins> fantasai: so ::scroll-marker originates from the element that generates it, correct? <TabAtkins> fantasai: but in the box tree it's a child of ::scroll-marker-group <TabAtkins> fantasai: where does it inherit from? <TabAtkins> flackr: its originating element <TabAtkins> fantasai: i think that's part of the confusion here. seems author would probably want it inheriting from scroll-marker-group <TabAtkins> flackr: there are some... it's useful to inherit ccustom properties from the target to set styles or content on the marker <TabAtkins> flackr: so it's a bit of a mix <fantasai> TabAtkins: when we support scroll markers that are real elements, much harder to change their inheritance patterns <TabAtkins> florian: so if you set 'color' on ::scroll-marker-group, that doesn't change the color on the ::scroll-markers inside of it, which is a bit surprising <TabAtkins> s/florian/fantasai/ <TabAtkins> fantasai: they'll get their color from their in-flow parent instead <TabAtkins> flackr: when we have real-element scroll markers, they *will* be children of the group <TabAtkins> flackr: there are just a lot of use-cases where it's useful to refer to properties in what it's pointing to <TabAtkins> fantasai: is it only custom properties? if you set font on scroll-marker-group it doesn't inherit to the markers. if you generate markers from headings and some have various text styles, they'll get a random mix. <TabAtkins> flackr: i suppose inheriting a counter is useful. you don't always want them to be counted separately <TabAtkins> fantasai: i think properties hsould inherit from the scroll-marker-group, but originating element is still the target element, so attr() or counter() returns the value from that element <TabAtkins> astearns: i think this is something we should consider, but not sure we'll get to a resolution on changing that today <TabAtkins> flackr: does it make sense to resolve on interactivity, and have an issue on inheritance generally? <TabAtkins> astearns: yes, people not in the room that probably have opinions <TabAtkins> flackr: i'll file an issue |
Let inertness set by interactivity be forced for the subtree using the same flag as for html inertness caused by modal dialogs and fullscreened elements. Also, let ::scroll-marker have a used inertness from its ::scroll-markers per resolution in [1]. The changed expectations in the inert reasons in the AX unit tests are due to the fact that we now cannot see from the IsInert() flag whether it was also set due to a modal dialog when the interactivity property is set to 'inert' at the same time. [1] w3c/csswg-drafts#11746 (comment) Bug: 370065759 Change-Id: I34b96698f1157b6fc49cce29daeb890114e58e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441921 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446485}
Let inertness set by interactivity be forced for the subtree using the same flag as for html inertness caused by modal dialogs and fullscreened elements. Also, let ::scroll-marker have a used inertness from its ::scroll-markers per resolution in [1]. The changed expectations in the inert reasons in the AX unit tests are due to the fact that we now cannot see from the IsInert() flag whether it was also set due to a modal dialog when the interactivity property is set to 'inert' at the same time. [1] w3c/csswg-drafts#11746 (comment) Bug: 370065759 Change-Id: I34b96698f1157b6fc49cce29daeb890114e58e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441921 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446485}
Let inertness set by interactivity be forced for the subtree using the same flag as for html inertness caused by modal dialogs and fullscreened elements. Also, let ::scroll-marker have a used inertness from its ::scroll-markers per resolution in [1]. The changed expectations in the inert reasons in the AX unit tests are due to the fact that we now cannot see from the IsInert() flag whether it was also set due to a modal dialog when the interactivity property is set to 'inert' at the same time. [1] w3c/csswg-drafts#11746 (comment) Bug: 370065759 Change-Id: I34b96698f1157b6fc49cce29daeb890114e58e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441921 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446485}
…tness, a=testonly Automatic update from web-platform-tests Don't allow interactivity to escape inertness Let inertness set by interactivity be forced for the subtree using the same flag as for html inertness caused by modal dialogs and fullscreened elements. Also, let ::scroll-marker have a used inertness from its ::scroll-markers per resolution in [1]. The changed expectations in the inert reasons in the AX unit tests are due to the fact that we now cannot see from the IsInert() flag whether it was also set due to a modal dialog when the interactivity property is set to 'inert' at the same time. [1] w3c/csswg-drafts#11746 (comment) Bug: 370065759 Change-Id: I34b96698f1157b6fc49cce29daeb890114e58e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441921 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446485} -- wpt-commits: 45196ff6c39bee2eadea8116fa349df53f95c168 wpt-pr: 51970
…tness, a=testonly Automatic update from web-platform-tests Don't allow interactivity to escape inertness Let inertness set by interactivity be forced for the subtree using the same flag as for html inertness caused by modal dialogs and fullscreened elements. Also, let ::scroll-marker have a used inertness from its ::scroll-markers per resolution in [1]. The changed expectations in the inert reasons in the AX unit tests are due to the fact that we now cannot see from the IsInert() flag whether it was also set due to a modal dialog when the interactivity property is set to 'inert' at the same time. [1] w3c/csswg-drafts#11746 (comment) Bug: 370065759 Change-Id: I34b96698f1157b6fc49cce29daeb890114e58e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441921 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446485} -- wpt-commits: 45196ff6c39bee2eadea8116fa349df53f95c168 wpt-pr: 51970
It's common practice to make the offscreen pages in a carousel inert, however, the
::scroll-marker
pseudo-elements generated for them should not be. In general, it would make sense for them to inherit their interactivity from the::scroll-marker-group
as this is the control into which they are placed.E.g. in the following example, only the current page is interactive, but the markers to go to the other pages are expected to be interactive.
The text was updated successfully, but these errors were encountered: