TR dark mode styles are low contrast (on view-transitions at least)

[vmpstr]

It seems like dark mode styles in some cases could use adjustments.
Seems to affect syntax highlighting:

compared to light mode:

This is from https://www.w3.org/TR/css-view-transitions-1/#example-b5766389

(not sure what labels to apply, but cc @fantasai @tabatkins)

[tabatkins]

Hmm, that's some recent breakage. I'll look into it.

[tabatkins]

Hmm, I'm confused. Both locally built, and viewing the /TR version you link to, I see reasonable text styling that differs from your screenshot:

What device are you viewing it from? Can you Inspect Element on that text and see if it's getting the correct gray color from a darkmode style, overriding the default black?

[vmpstr]

This is on my macbook, chrome stable:

[tabatkins]

I'm pretty confused here. It doesn't look like your browser is actually in dark mode, since your Inspector is light. Is this maybe using the Chrome "force dark" flag? iirc, that flag is pretty busted and doesn't work well with color-scheme. It's looking like none of the dark mode styles are active on the page, which implies something else is doing the background/text coloring.

[vmpstr]

Oh I'm typically in light mode, but once in a while the spec opens in dark mode with this toggle:

Not sure if that's busted? I don't mind switching to light mode and I'm glad that regular dark mode users don't see the problem. I guess it's light mode with this dark toggle that is a bit wonky

[tabatkins]

Ohhhh, I see the problem. That toggle is indeed busted. It doesn't actually trigger dark mode; it just sets a class on the body and enables a stylesheet that (without using the MQ) overrides all the color vars with dark values. That means all the Bikeshed-added styles that do depend on the MQ (like the highlight colors) don't work; they'll still apply their light-mode colors.

I'll fix, this is silly.