Skip to content

[css-rhythm] Handle margins at breaks for block-step-sizing #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fantasai opened this issue Apr 20, 2017 · 2 comments
Open

[css-rhythm] Handle margins at breaks for block-step-sizing #1260

fantasai opened this issue Apr 20, 2017 · 2 comments

Comments

@fantasai
Copy link
Collaborator

At unforced page breaks, the margin disappears. So if the style is set to insert additional “margin” when adjusting the height, it should not add to the side that has a truncated margin.

@fantasai
Copy link
Collaborator Author

fantasai commented Aug 4, 2017

Fixed in 45d60cd , @dauwhe would you mind reviewing to make sure this is the correct behavior? :)

fantasai added a commit that referenced this issue Oct 24, 2017
@dauwhe
Copy link
Contributor

dauwhe commented Oct 25, 2017

There might be a complication. With headings, often the space below the heading is fixed, but we're free to adjust the space above. The space below is important, because we want to keep the visual connection to the text that the head describes. But when a head occurs at the top of a column, sometimes it needs to be pushed down a bit so that everything below it aligns properly. See latinreq for a very simple illustration.

Here's a screenshot from a little toy example. In this case, the h2 needs 4pt of space above (shown dramatically in red) at the column break. If the heading were two lines it wouldn't need any.
unforcedbreak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants