Skip to content

[css-align] rules on synthesizing baselines are split across two sections #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbaron opened this issue May 22, 2017 · 2 comments
Closed
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-align-3 Current Work

Comments

@dbaron
Copy link
Member

dbaron commented May 22, 2017

At the end of the section on Baseline Alignment Terminology, there's a rule (a paragraph with two list items following) saying:

For the purpose of synthesizing baselines of boxes whose block flow direction is parallel to the axis of the alignment context:

  • If the box establishing the alignment context has a block flow direction that is orthogonal to the axis of the alignment context, use its writing mode.
  • Otherwise, assume either horizontal-tb or vertical-lr writing-mode, whichever is orthogonal to the box’s own writing-mode.

I think this should be in the previous section, on Determining the Baselines of a Box, since that's where the rules on synthesizing baselines are.

@fantasai
Copy link
Collaborator

Okay, I checked in a fix, but I had to actually change some of the prose in addition to moving it because the context wasn't there. I'd appreciate a review from you, @dbaron, and @tabatkins!

Loirooriol pushed a commit to Loirooriol/csswg-drafts that referenced this issue Jun 18, 2017
…nthesis to the section on synthesis, fill out missing details, and tighten up prose. Fixes w3c#1450.
@dbaron
Copy link
Member Author

dbaron commented Jul 19, 2017

Seems fine to me. (Although I wonder if the "use" in the first bullet should be "assume" like the others.)

@dbaron dbaron added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-align-3 Current Work
Projects
None yet
Development

No branches or pull requests

2 participants