Skip to content

[css-backgrounds] Description related to value order of 'border-image-repeat' is incorrect #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SebastianZ opened this issue May 27, 2016 · 3 comments

Comments

@SebastianZ
Copy link
Contributor

SebastianZ commented May 27, 2016

The spec. currently says:

The first keyword applies to the horizontal sides, the second to the vertical ones; see Drawing the Border Image.

That seems to be incorrect, because the first keyword sets the behavior for the top, middle and bottom parts of the image, i.e. all three vertical parts of the border image area, not the horizontal sides.

Sebastian

@astearns astearns added the css-backgrounds-3 Current Work label Jun 1, 2016
@SelenIT
Copy link
Collaborator

SelenIT commented Oct 27, 2016

This phrase looks quite ambiguous. On the one hand, the thickness of the top and bottom sides of the border is clearly measured along vertical axis. On the other hand, these parts are usually drawn like kind of horizontal bars, so some people might tend to think of them as of something with horizontal orientation.

Maybe it would be better to use terms like "top and bottom sides" directly, without trying to find one generalized term for both?

@SebastianZ
Copy link
Contributor Author

This phrase looks quite ambiguous.

Right. And even when the sentence is interpreted like horizontal bars, border-image-repeat also affects the middle area when border-image-source has the fill keyword set.

So, to be totally unambiguous I suggest to replace it by something like this:

"The first keyword applies to the horizontal scaling and tiling of the top, middle and bottom parts, the second to the vertical scaling and tiling of the left, middle and right parts."

Sebastian

@fantasai
Copy link
Collaborator

Fixed, thanks for the wording!

birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
These fixes address issues introduced in changeset
8efd180 and changeset
f43ecdf (issue w3c#148) and identified
during [review of the Gecko
implementation](https://bugzilla.mozilla.org/show_bug.cgi?id=1398038).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants