-
Notifications
You must be signed in to change notification settings - Fork 707
[css-display] 'flow' inner display type should never establish a BFC #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Despite mentioning that a block container can establish an inline formatting context, in the proposed text I forgot about that 😆. Anyways, I think this possibility should also be removed (at least for element-generated block containers), see #1617. |
I don't see the difference between these two.
Yup, inline box vs block box is the result of crossing {block, inline}x{flow}. That's fine.
We resolved that this makes sense to set at used value; making things establish a formatting context will now resolve "block flow" to "block flow-root" at used-value time. We're currently keeping "what happens if you make 'inline flow', 'inline ruby', or 'block ruby' establish formatting contexts?" undefined; we'll figure it out what 'contain' does on these elements separately. |
|
We don't make a real distinction between "filled only with inline content" and "filled only with block content". That's all flow layout. |
Checked in edits to define that “a block container that establishes a new block formatting context is considered to have a used @Loirooriol Let me know if that seems acceptable. |
It's acceptable, but in fact I no longer have a strong opinion about this. I wanted the But this does not work well for Then, I don't mind noting that if an element with |
Wait, it's not correctly written. It seems to imply that, if you have I think it should say "is considered to have a |
…' might have other values. #1550 (comment)
@Loirooriol Fixed, thanks. :) |
The Working Group just discussed
The full IRC log of that discussion<dael> Topic: 'flow' inner display type should never establish a BFC<dael> github: https://github.com//issues/1550 <fantasai> https://github.com//issues/1550#issuecomment-387160020 <Rossen> chris, thx :) <dael> fantasai: Comment ^ <dael> fantasai: We made an edit [reads] <dael> fantasai: We believe this is editorial and we wanted to flag the WG to confirm it's editorial <dael> [everyone reads] <dbaron> I think this may be hard to know until somebody tries implementing this... <dael> Rossen: You're saying a block container establishing a new fc inner display is flow root <dael> fantasai: Used inner display of flow root <dael> Rossen: Unless multicol? <dael> fantasai: I don't htink we have a display type for multi col. It would presumably have same. We're not changing computed value, jsut used. Currently that's just a concept. Only effect of flow root is it establishes a BFC. <dael> florian: I think multicol is desc as establishing BFC and I think I filed a bug saying that's weird. <dael> Rossen: Editorial part seems fine <dael> Rossen: I'll re-read the spec for multicol. <dael> Rossen: This particular one seems good <dael> fantasai: Multicol is difficult because it's a new type of FC. It's not really BFC but there's no display that aligns to it. <dael> fantasai: I'm wondering what dbaron is concerned about <dael> dbaron: I just think...I'm not aware of an impl and I think it's complicated and there will be side effects you discover once anybody tries to impl <dael> fantasai: atm I think no effect on impl. Only time it will start to have an effect is if we start to expose used values through OM <dael> Rossen: AS it stands... <dael> fantasai: That's the intent. If there's a different effect on impl it's not editorial <dael> Rossen: atm it's editorial because there's no impl <dael> Rossen: Objections to accepting the proposal https://github.com//issues/1550#issuecomment-387160020 <dael> RESOLVED: Accept proposal in https://github.com//issues/1550#issuecomment-387160020 |
The Working Group just discussed The full IRC log of that discussion<dael> Topic: Used value of display should convert flow to flow-root for BFC roots<dael> github: https://github.com//issues/1550#issuecomment-387160020 |
The
flow
inner display type is completely overloaded, it can generate 4 (!!!) different kinds of boxes: inline box, block container that establishes inline FC, block container that integrates into the parent BFC, or block container that establishes BFC.So I propose that
flow
never establishes a BFC. Instead, all cases which require a BFC are handled by switching the inner display type toflow-root
at used value time via becoming a formatting context. This would disentangleflow
andflow-root
. This change should have no effect in practice.Something like this:
And in Becoming a formatting context list these triggers:
overflow
applies and is different than visibleThe text was updated successfully, but these errors were encountered: