-
Notifications
You must be signed in to change notification settings - Fork 715
[css-fonts] @font-palette-values rule has no object model #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Best way is to make the interface |
(Comment left on commit.) |
@tabatkins you said
Sounds like you know exactly what you want, but we aren't sure and this issue is languishing. Care to gives us something copy-pastable? |
The "old DOM 2 Style class" I was referring to was CSSOMRGBColor; that interface is long obsolete and should never be used for anything. Just drop it from the signature. Then just define the error handling properly: use |
@tabatkins this was assigned to you my @litherum because, although you left hints on what needed to be done, neither of us was totally sure. Could uou make further comments so we can land the PR ? |
My last comment is exactly what you need to do.
and
rather than the existing vague "parsed as a solid color" wording. Plus it should throw on a parse error, not just return undefined and do nothing. |
I wasn't sure how to add to the interface to make it throw. |
Nothing on the interface. In the text, say:
|
https://drafts.csswg.org/css-fonts-4/#font-palette-values
This rule needs an enumeration added, for example
and a definition of the interface, something like:
???? No idea how in WebIDL to declare an unbounded set of descriptors whose names are the set of integers. Would that be a map?
Nor how to declare that it is
<color>
not just the DOM 2 CSS RGBColor.Also, those are really bad descriptor names, overly generic.
The text was updated successfully, but these errors were encountered: