Skip to content

[css-flexbox] Flexbox spec currently has "Printer" as its title #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dholbert opened this issue Jun 12, 2016 · 5 comments
Closed

[css-flexbox] Flexbox spec currently has "Printer" as its title #182

dholbert opened this issue Jun 12, 2016 · 5 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work Tracked in DoC

Comments

@dholbert
Copy link
Member

STR:

  1. Visit https://drafts.csswg.org/css-flexbox/
  2. Look at page title (in browser title bar, as well as the title printed at the top of the page)

ACTUAL RESULTS:
The title is "Printer" for some reason.

EXPECTED RESULTS:
The title should be "CSS Flexbox Layout Module Level 1" or something like that.

@dholbert
Copy link
Member Author

It looks like the spec does have an <h1> element about "Printer" in an example, further down the page. I'm guessing Bikeshed is getting confused and thinking that <h1>Printer</h1> is meant to be the page's title.

@dholbert
Copy link
Member Author

screenshot

@tabatkins
Copy link
Member

Whoops, indeed, recent change I made to let people put actual markup/attrs in their H1 (for i18n/etc) by just reusing the actual H1 in the document if present is misfiring here.

@tabatkins
Copy link
Member

And fixed in Bikeshed. Flexbox will rebuild shortly and have the correct title. ^_^

@dholbert
Copy link
Member Author

Looks like this is indeed fixed in the flexbox spec. Thanks!

@tabatkins tabatkins added the css-flexbox-1 Current Work label Jun 28, 2016
@fantasai fantasai added Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Feb 16, 2017
birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
CSS Property 'offset' is IDL attribute 'cssOffset'
@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work Tracked in DoC
Projects
None yet
Development

No branches or pull requests

3 participants